1
0

Bug in Patrick.net


               
2015 Dec 31, 1:27pm   1,309 views  6 comments

by Dan8267   follow (4)  

When ignoring a user, if he posts a comment on a site, the new post icon is still shown. Worst still, as a result clicking on that icon brings the user to the top of the thread instead of to new posts even if other users have posted after the ignored user. This makes navigation to the new posts difficult.

Steps to reproduce
1. Ignore user U1
2. Have user U1 post to thread T.
3. Have user U2 post to thread T.
4. Click on the new icon in the front page of Patrick.net for thread T

Expected behavior
The thread page will be loaded and jump to the post of U2.

Actual behavior
The thread page is loaded and stays at the top.

Debugging info
This bug is caused by the fact that the URL contains an anchor tag to the ignored user's post but the web page does not contain that anchor tag.

Suggest Fix 1
Update the SQL statement producing the front page results to not pull in posts from ignored users.

Suggest Fix 2
Update the web page for threads to put a div tag of zero height with the anchor tag for the post ID of an ignored user's post.

Either fix will do although fix 1 has the additional benefit of not showing new activity for ignored users. Fix 2 is probably easier to implement.

Comments 1 - 6 of 6        Search these comments

1   Patrick   2015 Dec 31, 3:53pm  

Dan8267 says

This bug is caused by the fact that the URL contains an anchor tag to the ignored user's post but the web page does not contain that anchor tag.

yes, that is the cause.

here is the code responsible:

// If post_modified > last time they viewed this post, then give them a link to earliest unread comment.
if (strtotime($post->post_modified) > strtotime($last_view[$post->post_ID])) {
$since = strtotime($last_view[$post->post_ID]);
$unread = " post_ID&since=$since' >";
$unread .= "
  ";
}

(note that post means the same thing as thread)

code got a bit manged in posting it, but you can see that all i do here is a quick check of post_modified time (which will be updated on each new comment) vs the time the user last viewed the post.

if there is a new comment by an ignored user, then that thing will indeed give a "new comment" icon for a post where the user does not want to see the comment.

so it's not quite clear how to fix that. i guess that i have to specifically look for the last unseen comment which was created by a non-ignored user. more complicated, but doable.

2   Dan8267   2016 Jan 1, 2:09pm  

Patrick, the thing is no one really wants an "ignore" function. They want a "block" function.

I understand that you may want to use the blocking ability as a carrot to get people to just ignore trolls, but it just doesn't work. Trolls content still leaks through and people still but heads even if they have a troll on ignore. As a result, the ignore functionality isn't used by enough people to discourage trolling at all.

In contrast, if you had a block function that just prevented blocked users from posting on threads, a lot more people might use the feature and create a troll-free zone within Patrick.net. Yes, the trolls will still open their own threads, but at least they wouldn't be disrupting most other threads. The fact is that the vast majority of threads opened on Patrick.net are opened by a dozen or so users. If most of these users blocked trolls, there would be much less personal bickering and more actual discussion on this site.

Consider adding a proper block function rather than ignore. The two features are independent of each other anyway.

3   Dan8267   2016 Jan 1, 4:07pm  

marcus says

So, your point is taken, but that's why you need to ignore the people that you consider trolls.

Ah, but that means giving no opposition to evil, and that's how evil wins.

4   justme   2016 Jan 2, 12:23pm  

Speaking of bugs and/or features: I just refreshed the top level page, and I can then

1. see a comment by a user (=Ironman/CIC), whom I have on ignore.
2. that user quoted something I said and commented on it.

Now, 1 is just because the front page will show a snippet of the most recent post. But 2 is kind of annoying. After having thought it over, I realize I'd not really want to prevent anyone from quoting and commenting on my post. I don't want be similar to some social justice warriors that demand a safe space, which is just another name for censorship, among other things. So what alternatives are there? Well, I suggested before that each poster byline might include an ignored-by-COUNT. Does it make sense?

The following is what I saw on the front page:

Privilege, power and pathology
By tovarichpeter 7 comments, latest 5 minutes ago:
Ironman says justme says I though only egomaniacs and narcissists populated that place. No, you have them confused with the Libbies here at Patnet.

5   Patrick   2016 Jan 2, 6:41pm  

justme says

I suggested before that each poster byline might include an ignored-by-COUNT.

ok, now each byline includes that ignored-by count.

6   justme   2016 Jan 2, 9:06pm  


ok, now each byline includes that ignored-by count.

Works great, might also be good to have on the thread byline. Thanks!

Please register to comment:

api   best comments   contact   latest images   memes   one year ago   users   suggestions   gaiste