forgot password register

reset password

register

patrick.net

 

#patnet


#housing #investing #politics #random more»
771,795 comments by 11,159 registered users, 7 online now: crazydesi, Heraclitusstudent, HEY YOU, iwog, justme, TwoScoopsMcGee, WookieMan
new post
« prev   patnet   next »

-3

PatNet Improvement Suggestions

By Dan8267 following x   2017 Jan 28, 1:48pm 46,154 views   210 comments   watch   quote     share  

Thread for idea submission for PatNet improvements

#patnet

« First    « Previous     Comments 161 - 200 of 210     Next »     Last »

161 Patrick   2017 Aug 19, 3:00pm   ↑ like (0)   ↑ dislike (0)     quote        

Yes, thus the conversion to node.

162 jazz_music   2017 Aug 19, 3:09pm   ↑ like (1)   ↑ dislike (1)     quote        

I certainly look forward to the ignore feature working again.

163 Patrick   2017 Aug 22, 12:36pm   ↑ like (0)   ↑ dislike (0)     quote        
OK, up next, ignore feature.
164 Dan8267   2017 Aug 22, 12:58pm   ↑ like (0)   ↑ dislike (0)     quote        
Patrick says
OK, up next, ignore feature.


Here's how to implement that feature.

On the home page
1. Actually deliver the content, but hide it in a div with display: none.
2. Show a link "Show N ignored messages".
3. If you click that link, set each ignored thread's div to display: block.

On a thread page
1. Again, deliver the content, but hide it in a div with display: none.
2. The reply index should not be affected. Even ignored posts get a post index.
3. Each ignore post should have a visible link like "index. [username] Show". For example, "23. Blue Sardine Show   Show All".
4. Clicking the "Show" link shows that post. Clicking the "Show All" link shows all posts for that user in the current thread.
165 Dan8267   2017 Aug 22, 12:59pm   ↑ like (0)   ↑ dislike (0)     quote        
Layout bug: When quoting someone, lots of line breaks are being added. See prior post.
166 Dan8267   2017 Aug 22, 1:00pm   ↑ like (0)   ↑ dislike (0)     quote        
Also, the "new post" bug when you post a reply is still there.
167 Dan8267   2017 Aug 28, 12:45pm   ↑ like (0)   ↑ dislike (0)     quote        
@Patrick, new bug.

1. Go to any thread.
2. Select text from a post.
3. Click the quote link.

The text inserted into the comment box reads "[username] says" where username is the name of the logged in user rather than the name of the user being quoted.
168 Patrick   2017 Aug 28, 1:04pm   ↑ like (0)   ↑ dislike (0)     quote        
Dan8267 says
The text inserted into the comment box reads "[username] says" where username is the name of the logged in user rather than the name of the user being quoted.


You're right! Thanks for telling me.

OK, fixed now. Here is the fix:

https://github.com/killelea/node.patrick.net/commit/281f687970ecc34598d23c1018c07f25afb71253
One more problem I'm having: since moving from php to node, certain characters are not displaying correctly. I don't understand why, since I am using <meta charset='utf-8' /> in the html just like before.
169 Dan8267   2017 Aug 28, 1:19pm   ↑ like (0)   ↑ dislike (0)     quote        
Patrick says
One more problem I'm having: since moving from php to node, certain characters are not displaying correctly. I don't understand why, since I am using <meta charset='utf-8' /> in the html just like before.


Example? A guess: it may be that your font doesn't have glyphs for those characters.
170 Patrick   2017 Aug 28, 1:29pm   ↑ like (0)   ↑ dislike (0)     quote        
Check out https://patrick.net/post/1309428/look-at-the-democrats-trying-to-weasel-out-of-their-confederate-heritage
Here are some of the characters that won't display properly:


Happens the same on multiple browsers.
171 Dan8267   2017 Aug 28, 2:53pm   ↑ like (1)   ↑ dislike (1)     quote        
The characters "“inspiration”" appear in the post. In hexadecimal the post is
C3 A2 E2 82 AC C5 93 69 6E 73 70 69 72 61 74 69 6F 6E C3 A2 E2 82 AC C2 9D.

The offending characters are codes
C3 A2 E2 82 AC C5 93 before "inspiration" and
C3 A2 E2 82 AC C2 9D after "inspiration".

C3 A2 should be rendered â, the Latin lowercase letter a with cricumflex.
E2 82 AC should be rendered €, the Euro symbol.
C5 93 should be rendered œ, the Latin lowercase ligature oe.
C2 9D is unused and should be rendered as blank space.

I doubt TPB knows how to add any these characters to a post, so it might be something screwed up in your processing of the posted text. Also, if you are using a varchar instead of a nvarchar, only Latin characters would be supported.

See http://utf8-chartable.de/unicode-utf8-table.pl for details on Unicode codes with UTF-8 encoding.
172 Dan8267   2017 Aug 29, 1:47pm   ↑ like (0)   ↑ dislike (0)     quote        
test
173 Dan8267   2017 Aug 29, 1:51pm   ↑ like (1)   ↑ dislike (1)     quote        
@Patrick, there's a major bug or bugs with posting comments to some threads.

I've notice that when I've clicked on certain threads with the "new comment" link, the thread shows no new comments and the page is at the top of the thread. For example, the Funny Picture thread.

I've also notice that all the comments are missing from the thread "Too soon for Texas & Harvey jokes?" if you go it via a link with the offset parameter like
https://patrick.net/post/1309403/?offset=28758#comment-1437445 but they are there if you go to the link without the offset parameter
https://patrick.net/post/1309403
This means that if you post to a thread, you don't see your comments or anyone else's.
174 Patrick   2017 Aug 29, 3:55pm   ↑ like (0)   ↑ dislike (0)     quote        
Dan8267 says
I've notice that when I've clicked on certain threads with the "new comment" link, the thread shows no new comments and the page is at the top of the thread. For example, the Funny Picture thread.


Did you mean the "latest" comment link on a list of posts? That was broken until just now:

https://github.com/killelea/node.patrick.net/commit/8abd294ffdf7d8266f5016732882b4b88245cd39
Dan8267 says
This means that if you post to a thread, you don't see your comments or anyone else's.



Seems to work OK for me. I just posted this comment to a thread, and upon posting, I see it.
175 Dan8267   2017 Aug 29, 4:18pm   ↑ like (0)   ↑ dislike (0)     quote        
Patrick says

Did you mean the "latest" comment link on a list of posts?

yes
176 Philistine   2017 Aug 29, 10:05pm   ↑ like (1)   ↑ dislike (1)     quote        
Patrick, it seems the Like:Dislike quotient is always one for one in the latest comments. It's too much of a coincidence that a comment has 2 likes and 2 dislikes, or 4 likes and 4 dislikes, etc.

Or maybe we have reached brainwash parity on PatNet?
177 zzyzzx   2017 Aug 30, 11:32am   ↑ like (1)   ↑ dislike (1)     quote        

If it actually worked in Chrome on an android phone, that would be an improvement.

178 Philistine   2017 Aug 30, 1:19pm   ↑ like (2)   ↑ dislike (2)     quote        
Philistine says
Patrick, it seems the Like:Dislike quotient is always one for one in the latest comments

So, Patrick, did you fix this, or did it just fix itself? Everything back to normal now. Bizarre-o Land!
179 Patrick   2017 Aug 30, 3:21pm   ↑ like (0)   ↑ dislike (0)     quote        
I did not change anything about like vs dislike lately.

@zzyzzx is the site still broken in Chrome on Android? If so, what happens? Just blank, hang, or something else?
180 Patrick   2017 Aug 30, 3:27pm   ↑ like (0)   ↑ dislike (0)     quote        
This comment is being made with Firefox on Android.
181 Patrick   2017 Aug 30, 3:28pm   ↑ like (0)   ↑ dislike (0)     quote        
Well, Firefox on Android seems OK.
182 Patrick   2017 Aug 30, 3:45pm   ↑ like (0)   ↑ dislike (0)     quote        
This is a comment from Chrome on Android.
183 Dan8267   2017 Aug 30, 3:46pm   ↑ like (0)   ↑ dislike (0)     quote        
Dan8267 says
@Patrick, there's a major bug or bugs with posting comments to some threads.

I've notice that when I've clicked on certain threads with the "new comment" link, the thread shows no new comments and the page is at the top of the thread. For example, the Funny Picture thread.


This is because @Patrick replaced ban with ignore. There are all sorts of bugs with ignore including showing the "new comment" link for ignored users and then when you click on it, you don't see a new comment.

Ignore and ban should be independent features, but if you are going to marry the two, and I advise against that, then at least make the ignore go both ways, so that the person you ignore cannot see your posts. Also fix the new comment bug with ignore, as that's a very annoying bug that alone makes ignore not worth using. This could be done using a left join with your ignore table and checking for null in the where clause.
184 Patrick   2017 Aug 30, 3:46pm   ↑ like (0)   ↑ dislike (0)     quote        
Still no problem. So I cannot reproduce it.
185 Patrick   2017 Aug 30, 3:47pm   ↑ like (0)   ↑ dislike (0)     quote        
Dan8267 says
showing the "new comment" link for ignored users


Ah thanks, will fix that.
186 Dan8267   2017 Sep 11, 6:51am   ↑ like (0)   ↑ dislike (0)     quote        
@patrick, I suggest setting up URL forwarding from old URLs to new site's URLs. Google search results yield error pages. That's not good for your ranking.

For example, https://patrick.net/Leftists+and+Social+Justice+Warriors+are+Conservatives 404: LeftistsandSocialJusticeWarriorsareConservatives was not found
187 Dan8267   2017 Sep 29, 10:54am   ↑ like (1)   ↑ dislike (1)     quote        
@Patrick, the links to posts are frequently messed up. This includes the "first unread post" on the index page and the links to posts in the user's comments page.

Here is an example of one of the links from a user page that takes you to a page with no comments.
https://patrick.net/post/1310376/?offset=29093#comment-1444009
I do not know the cause of this bug, but a good place to start looking is at edge cases like the first or last comment on a page.
188 WookieMan   2017 Sep 29, 12:20pm   ↑ like (1)   ↑ dislike (1)     quote        
@Patrick, may have been suggested before. Have you ever thought about allowing a post to be saved prior to posting? Not comments, but originating a new post. Sometimes life happens and you're getting something good down and have to run off. I know you could always just create your posts in word or some other program and then copy and paste. So this may be a silly suggestion.
189 WookieMan   2017 Sep 29, 12:22pm   ↑ like (1)   ↑ dislike (1)     quote        
@Dan8267, noticed the same thing. You beat me to it.
190 Dan8267   2017 Sep 29, 3:46pm   ↑ like (0)   ↑ dislike (0)     quote        
@Patrick, another bug. Some HTTP requests for images are returning the text "content was not found". It's also returning a 404 status.

191 Patrick   2017 Sep 29, 9:04pm   ↑ like (0)   ↑ dislike (0)     quote        
Thanks Dan, that /content/uploads/2011/12/excuse.jpg link refers to an image which is simply not on the server. I did not delete it. Kind of disturbing that it's gone.

Other images from that month are still there. I'll check my backups to see the last time I had excuse.jpg.
192 Patrick   2017 Sep 30, 12:54pm   ↑ like (0)   ↑ dislike (0)     quote        
Dan8267 says
Here is an example of one of the links from a user page that takes you to a page with no comments.


OK, at least all the comment permalinks should work correctly now. So when you click on the date/time of any comment, even in a user's comment list or a search result, you should go to the right comment.
193 goat   2017 Oct 1, 6:17pm   ↑ like (1)   ↑ dislike (1)     quote        
I want a live post/comment editing preview. I'm always frustrated editing the raw html every time I quote someone - it's hard to read with no indentation to help me decide what parts to remove. Being able to see it rendered as I type would at least help with that a bit. It's easy too:

<textarea id="textArea"></textarea>
<h3>Post Preview</h3>
<div id="preview" style="padding: 1em; border: 1px solid #aaa;"></div>
<script>
var textArea = document.querySelector('#textArea');
var preview = document.querySelector('#preview');
textArea.addEventListener('input', function updatePreview(){
preview.innerHTML = textArea.value;
});
</script>
194 goat   2017 Oct 1, 6:30pm   ↑ like (0)   ↑ dislike (0)     quote        
On the same note, it would also be nice if the html presented to me when I quote someone was just plain easier to read. Use indentation and newlines to help. Eg

Formatting example: https://codepen.io/anon/pen/zEdRqr
Ideally, it would support adding a new additional level of indentation for each nested quote, like shown above. But, that's harder to code because you'd have to parse it and reassemble it with indentation. But, it should be very easy to make at least the top level a & blockquote tags be formated, and the content indented 1 level, and that would still help most use cases.
195 Patrick   2017 Oct 1, 6:33pm   ↑ like (0)   ↑ dislike (0)     quote        
Thanks goat! This is a good idea.

I actually format text on the server side, so that's a complication. Maybe I should not do that, but let people compose entirely in the browser in wysiwyg mode, and then post to the server only when they save.

Anyone know a good wysiwyg editor I can use?
196 Dan8267   2017 Oct 1, 8:25pm   ↑ like (1)   ↑ dislike (1)     quote        
goat says
preview.innerHTML = textArea.value;


Hmmm, how can I exploit this to inject JavaScript?
197 goat   2017 Oct 4, 7:54pm   ↑ like (1)   ↑ dislike (1)     quote        
Dan8267 says
goat says
preview.innerHTML = textArea.value;


Hmmm, how can I exploit this to inject JavaScript?


I guess it's not apparent from the post, but it's meant as a sample. I spoke with him recently about his html stripping strategy, and felt it was obvious that he should plug the same stripping code into this. Otherwise, the preview could be quite a bit different than what you see after you post.

Even if used as-is though, I think it'd be tough to exploit. Maybe if you can coerce someone into manually copy pasting code into the textbox.

Patrick, I agree and think a wysiwyg editor is the better direction to head in. My idea is just a monkey patch.
198 Dan8267   2017 Oct 6, 12:28am   ↑ like (0)   ↑ dislike (0)     quote        
test
199 Dan8267   2017 Oct 6, 12:30am   ↑ like (0)   ↑ dislike (0)     quote        
test2
200 Dan8267   2017 Oct 6, 1:03am   ↑ like (0)   ↑ dislike (0)     quote        
OK, here's the problem, @Patrick.

In the old site you did a full postback when a user submitted a comment. As such, the user could always click the browser's back button to get back to the page state where his comment was in the text area control.

In the new site you are doing a partial postback with the request body containing key/value pairs separated with ampersands. Example:
comment_content=test2&comment_post_id=1302130


In the response body you are giving the HTML of the new or edited comment. I would give you an example of that, but I get an alert saying "database failed to accept some content".

I assume you have a JavaScript handler, perhaps using a third party library or framework, that inserts the returned HTML subtree into the DOM at the appropriate point and then clears the contents of the text area with the ID "ta". You do this without using the HTML 5 History API and thus the prior content of the text area is lost for good.

What you should do is use the pushState(stateObject, title, url) function to save the text of the text area "ta" so that if the user presses the back button the state is popped and the text area is restored.

Here's a JS Fiddle I threw together to demonstrate the concept.
1. Enter the following text in the text area: This is the index page.
2. Click on Page 1. Notice the text area goes blank.
3. Enter the text: This is page 1.
4. Click on Page 2. Notice the text area goes blank.
5. Enter the text: This is the second page.
4. Click on Page 3. Notice the text area goes blank.
5. Press the browser back button. Notice the text area now says, "This is the second page.".
6. Press the browser back button. Notice the text area now says, "This is page 1.".
7. Press the browser back button. Notice the text area now says, "This is the index page.".
8. Press the browser forward button. Notice the text area now says, "This is page 1.".
9. Press the browser forward button. Notice the text area now says, "This is the index page.".
10. Press the browser back button. Notice the text area now says, "This is page 1.".

No full postbacks. No loss of text history. 100% HTML 5 compliant.

« First    « Previous     Comments 161 - 200 of 210     Next »     Last »

users   about   suggestions   source code   contact  
topics   best comments   comment jail  
10 reasons it's a terrible time to buy  
8 groups who lie about the housing market  
37 bogus arguments about housing  
get a free bumper sticker:

top   bottom   home