patrick.net

MolotovCocktail says

Then I don't see any of those 23 comments.

@MolotovCocktail According to the DB, you did have him on ignore. I removed that.

If you didn't do it, I have some kind of bug.

Patrick says

MolotovCocktail says

Then I don't see any of those 23 comments.

MolotovCocktail According to the DB, you did have him on ignore. I removed that.

If you didn't do it, I have some kind of bug.

Yeah. I think I set him to that. My bad.

It would be nice if I were able to login using 2 devices at the same time. It's annoying if I get up from my computer (logged in), go out to the living room and use my phone but need to log in again for some of the content. Like the tits thread. That is worth logging in for.

@Maga_Chaos_Monkey

You should be able to remain logged in on two or more devices. I leave my laptop and phone logged in all the time, no problem.

Do you get logged out if you log in on a different device?

I am able to log in simultaneously on a Windows 11 computer and an iPhone.

I know what the problem is. I log in the easy way: forgot-my-password, that's what's logging me out of the prior device.

I can log in on my cell phone with one hand while I eat a sammich with the other hand that way. I can't remember those UUID passwords though once generated unless I save them.

Yes, the forgot password form will reset your password to something new, and your password is used in creating the cookie that defines being logged in. So changing your password will log out every device logged in with the old password, which is actually good for security in case you leave a public device logged in as you by mistake.

You could reset your password to something memorable at https://patrick.net/edit_profile

Then use that password to log into any number of devices at the same time.

User Error lol

I've made some major improvements to the speed of retrieving comments by reworking how it's done.

Please let me know if you notice any bugs introduced by that.

Patrick says

I've made some major improvements to the speed of retrieving comments by reworking how it's done.

Please let me know if you notice any bugs introduced by that.

Now all I see is the latest comments on their own page. All previous comments are on previous pages. If there's only one new comment in a thread, that's the only comment that appears other than the OP.

stereotomy says

Now all I see is the latest comments on their own page. All previous comments are on previous pages. If there's only one new comment in a thread, that's the only comment that appears other than the OP.

Yeah. So far about that:

I post a new comment, see the above. I have to hit Previous and then hit Next to see it all on one page as before.

@stereotomy @MolotovCocktail

OK, I've fixed the thing with the new comment. It should show up as the last comment on a page now, with other comments before it.

I'm still observing the same behavior. Right now in this thread all I see is post #1 and #695.

its weird, first time clicking into a thread I only see one comment, happens a lot.

Hold on - after I posted my last comment, things seem to be fixed. Thanks!

EDIT: Things only appear normal right after I post a new comment to a thread. If I view new comments without posting or editing, all I see is the first and last comments. This includes viewing my most recent comment once I step away from the thread.

I always just see one comment.

Huh, I now have url options to view 40 before a given comment, or 40 starting at a given comment, or 40 after a given comment, or just the last page of comments.

Say there is a single new unread comment on a thread, and you click on that thread on the home page.

If I choose before that unread comment, you see 40, but not that one.
If I choose starting at that unread comment, that's the only one you see, because there's only one unread comment.
If I choose after that unread comment, there is nothing there.
If I choose last page, that would work for that single comment case, showing you the whole last page... except then if you're trying to read an unread comment is more than 40 before the last comment, then now that case would be broken.

OK, if an unread comment is more than 40 before the last comment, then I should use start at.
But if there are fewer than 40 before last comment, then show last page.

I'll see if I can do that.

FortWayneHatesRealtors says

its weird, first time clicking into a thread I only see one comment, happens a lot.

I saw that about an hour ago, too.

OK, fixed now?

What this site mostly does is select a window of a sparse subset of the comments table. That spares subset could be:

- all the comments on a thread
- all the comments by a user
- all the comments matching a search

It was getting painfully slow to view comments in a large result set because the URLs were using the ordinal number in the total result set to select which window of comments to show. Calculating those ordinal numbers required sorting every row in the comments table, which now has 1.3 million comments.

The new way is to use comment_ids in the URLs. That lets me select ranges, which is way faster. So now if you page through some thread or some user's comments, it should be 10x faster.

But working with comment_id's instead of "nth to mth comment in total result set" forced me to rework tons of code, resulting in unforeseen problems like the ones above.

I think that did it. Thanks Patrick!

I've added an @ in each comment header after the user name.

If you click it, it puts @that_user in the comment box and pops down there so you can type a message to the attention of a specific commenter.

Patrick says

OK, fixed now?

Looks great, thank you