patrick.net

Oh wow, so many things to fix already! I can do this.

Two more bugs. The home page says "page 1 of NaN". Also clicking the last comment of a thread link gives a bad anchor tag in the url. For example,
patrick.net/post/1309179/new-version-of-patrick-net-is-live#comment-null

Notice the comment number is "null".

First bug to fix: get new comment to just show up in the right place without "undefined" as the number.

Also, no next page link on the home page.

The new PatNet site is buggier than the Obamacare site!

The old site is still available at http://php.patrick.net but you'd have to log in again to use it.

OK, too many bugs, reverting main https://patrick.net to the old php site for now.

Today I had a thought: your forum has opportunity to grow tremendously given the rampant thought-policing on other platforms that is driving people away. I hope this site can grow into something that makes you wealthy! (or, wealthier!).

Patrick says

OK, too many bugs, reverting main https://patrick.net to the old php site for now.

I thought you were just really really fast and efficient (after seeing all the bugs earlier).

marcus says

Please bring back ignore Patrick. IT was better than ban.

Ignore and ban serve two entirely different purposes. There are people I'd ban but not ignore, and people I'd ignore but not ban. They should be independent functions. They are not mutually exclusive.

The site would be perfect if it wasn't for the Patnetters.

The Obnoxiousness Filter erased everybody but me!

OK, I fixed the major bugs, and we're back on node now. Please tell me about new bugs here, or write p@patrick.net

marcus says

Please bring back ignore Patrick.

Yes, that's next on the list after I make sure that the node version of the site functions acceptably well.

steverbeaver says

Today I had a thought: your forum has opportunity to grow tremendously given the rampant thought-policing on other platforms that is driving people away.

Sure, please send people this way!

Hmmm, more bugs. Extra blank lines getting inserted in comments, and email address links get munged after edit and save.

Munged lol

Great word!

And image upload works on my test system, but not on the live server.

Got to revert to php again while figuring this out. :(

So what is this new format?

What changes will we notice

Ceffer says

The Obnoxiousness Filter erased everybody but me!

None of us would be here it Patrick had an Asshole Filter.
Made someone smile,a little?

Ahhh triggered before i even post.
Excellent!
Dan8267 says

Another major bug: Blue Sardine can still post.

Prepost triggering is new...
errc says

So what is this new format?

What changes will we notice

No you are not.
What you are is self-evident...

Dan8267 says

Also, I'm "undefined"

I keep checking. No ignore,yet?

HEY YOU says

I keep checking. No ignore,yet?

Not yet. Just got to get the node version to an acceptable state first.

errc says

So what is this new format?

What changes will we notice

Hopefully very little at first. Comments will be posted without a page reload. Login will happen similarly. Should feel faster.

OK, I fixed all the bugs found so far and re-deployed the node version.

So that's what we're all using right now.

I expect something else to be borken (as they say) so please write here and let me know if you find a bug.

Woohoo! An hour and a half and no new bugs found!

I take it back, Dan8267 has some, here: https://patrick.net/post/1302130/?offset=160#comment-1436338
Nothing too bad though.

Patrick says

OK, I fixed all the bugs found so far and re-deployed the node version.

Nope. Still has the "new comments" bug.

How about fixing the bug of Assholes posting threads & comments?

Dan8267 says

Patrick says

OK, I fixed all the bugs found so far and re-deployed the node version.

Nope. Still has the "new comments" bug.

Tell me more about this bug.

When I post a new comment, it looks OK to me. It doesn't have a comment number, but other than that seems fine.

What do you see? Can you post a screenshot?

Patrick says

Tell me more about this bug.

1. Read any thread.
2. Post a comment to that thread.
3. Return to patrick.net/
4. The thread where you just posted a comment will be marked "new comments" even though you just read it, including the comment you posted.

Bug is independent of browser used.

Thanks, yes it's a bug.

When I read a thread like this one and I get to comment #40, you give me two options

Next>>> which takes me back to post 8, but on a new page where I can scroll down to comment #41

Or

Last>>>>> which takes me to the last comment in the thread

How about an option that takes me to the next comment, in this instance, #41?

@Patrick, you should set up URL forwarding rules on the new site so that the old URLs to threads will go to the URLs used by the new site. For example, the path for the Funny Pictures thread on the old site was /1200568/2011-12-09-funny-picture-thread whereas the path on the new site is /post/1200568/funny-picture-thread. Your URL redirection should include the HTTP code for permanent redirect.

Doing this will have several advantages. First internal and external links won't break. Second Google will update its model of your site, keeping your page ranking high. Google does not like broken links. Third, the Google search results won't take users to an error page. Most users will simply close a tab if an error page is shown.

Yes, also need to do that.

errc says
How about an option that takes me to the next comment, in this instance, #41?


The tricky bit there is that I always want a full page of comments (40 comments) to appear, not just one or a few comments. So I do a bit of math to make the pages always start with a comment that will result in a filled page.

So in this case, the next page started with comment 8 so that the page contained the last 40 comments in the thread (8 to 47). The php site actually worked the same way.

Is there a better way to do that?

When I'm finished reading comment #40, and I hit next, and you jump me to a page with comments 8-47, is there any way to start me 80% down the page at comment #41?

Or do you expect me to do all the work and scroll down the page myself?

I could have logic that says "if you were just on the previous page of comments, and it was not a full page since it was at the beginning, then go to the next unread comment on the next page".

OK, not that hard, on the list.

Dan8267 says

ou should set up URL forwarding rules on the new site so that the old URLs to threads will go to the URLs used by the new site. For example, the path for the Funny Pictures thread on the old site was /1200568/2011-12-09-funny-picture-thread whereas the path on the new site is /post/1200568/funny-picture-thread.

OK, the old site links work now. Not a redirection, just one line of code that adds in /post if the url starts with a number.
So we're back on node, and this link should work: https://patrick.net/1200568/2011-12-09-funny-picture-thread

Dan8267 says

4. The thread where you just posted a comment will be marked "new comments" even though you just read it, including the comment you posted.

This is also fixed now. Thanks for pointing it out.

All versions of patnet have always done this...

errc says

When I'm finished reading comment #40, and I hit next, and you jump me to a page with comments 8-47, is there any way to start me 80% down the page at comment #41?

BlueSardine says

All versions of patnet have always done this...

errc says

When I'm finished reading comment #40, and I hit next, and you jump me to a page with comments 8-47, is there any way to start me 80% down the page at comment #41?

It's the AltLefts fault

All of it

They've single handily ruined everything, while the rest of us sat around mean mugging our computer screens.

If only we could figure out how to defeat the AltLeft and the Media that they control, which is all of it, then us Great Americans can finally have our ideas heard. It will be heaven